Fixing HGCal Hexagonal Geometry Round 1 #13038
Conversation
|
@cmsbuild please test |
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
The tests are being triggered in jenkins. |
|
-1 >> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HFShowerLibrary.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HFShowerPMT.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HFShowerParam.cc
>> Compiling /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HGCNumberingScheme.cc
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HGCNumberingScheme.cc: In member function 'uint32_t HGCNumberingScheme::getUnitID(ForwardSubdetector, int, int, int, int, const G4ThreeVector&)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HGCNumberingScheme.cc:48:14: error: 'hgcons' was not declared in this scope
wafer = hgcons->waferFromCopy(module);
^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-21-2300/src/SimG4CMS/Calo/src/HGCNumberingScheme.cc:58:11: error: 'check_' was not declared in this scope
if (check_) {
^
you can see the results of the tests here: |
|
oops, forgot a commit. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Pull request #13038 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
-1 Tested at: 2295abc ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
|
Pull request #13038 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Fixing HGCal Hexagonal Geometry Round 1
This PR fixes a number of bugs in the HGCal geometry.
Previous to this PR the HGCal Hex geometry did not produce simhits.
Event display for RECO geometry of pT = 35 GeV electron seems to be OK.
Likewise, energy distributions look good now.
While simulating, there are still invalid detids encountered in the sensitive detector, so I do not think we are done yet.
@bsunanda